Open
Conversation
Collaborator
Author
|
I think using a hash for the event slot index is the better solution. It provides consistency from run to run (it doesn't depend on the order in which events are created) and it will still distribute the slots evenly. No need for the extra complexity of a sequential number. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is only a single
Eventthat gets triggered for all message topics. Each subscription waits on this event and after it wakes up it checks if there is a new message for them. If there is not, that is, a message on another topic was submitted instead of their topic, then they go back to sleep on the event once again. This however leads to every waiting thread waking up on every message, with each thread vying for the same CPU time. This problem is known as the thundering herd problem.We can alleviate this problem by having a single Event per topic. However, since everything needs to be created at creation time of the message broker, this means that we need to allocate 65000+ events, something that is not feasible. Instead, we create a pool of events (128 in this PR) and use the hash of the topic to index into that pool. That way, the waiting threads are separated into separate bins and are not woken up accidentally as much. Only in cases of collision are threads woken up accidentally.
TODO