Move service heartbeat and service state on broker#396
Open
Move service heartbeat and service state on broker#396
Conversation
Collaborator
Author
|
I ran into a bug where message headers were not cleaned up properly. This bug is, I think right now at least, unrelated to this PR. It however started when an infinite loop of publishing arrays (heartbeats) were done. |
Also move heartbeat generation to property and command monitoring thread.
This avoids an infinite loop where a heartbeat triggers another heartbeat.
ehpor
force-pushed
the
feature/service_heartbeat_and_state_on_broker
branch
from
94c2fd9 to
94d3853
Compare
ehpor
changed the title
Collaborator
|
The code changes look globally good to me. @ehpor is there an appropriate hardware test this should be run in? And would this be better done after resolving the existing conflicts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #392. Do not review before that PR is merged.
This PR moves the heartbeat and state of services onto the message broker. This is part of an ongoing effort to move as much information as possible on the message broker.