Update protobuf binary directory path in CMakeLists.txt to avoid a compilation issue on Rocky Linux 9#386
Open
Update protobuf binary directory path in CMakeLists.txt to avoid a compilation issue on Rocky Linux 9#386
Conversation
…compilation issue on RockyLinux 9
FAILED: [code=1] catkit_core/CMakeFiles/catkit_core.dir/__/proto/core.pb.cc.o
/usr/bin/g++ -pthread -B /home/micado/miniforge3/envs/catkit2/compiler_compat -DPROTOBUF_USE_DLLS -I/tmp/tmpt925y22a/build/catkit_core -isystem /home/micado/miniforge3/envs/catkit2/include -isystem /home/micado/miniforge3/envs/catkit2/include/eigen3 -O3 -DNDEBUG -fPIC -g -std=gnu++17 -MD -MT catkit_core/CMakeFiles/catkit_core.dir/__/proto/core.pb.cc.o -MF catkit_core/CMakeFiles/catkit_core.dir/__/proto/core.pb.cc.o.d -o catkit_core/CMakeFiles/catkit_core.dir/__/proto/core.pb.cc.o -c /tmp/tmpt925y22a/build/proto/core.pb.cc
cc1plus: fatal error: /tmp/tmpt925y22a/build/proto/core.pb.cc: No such file or directory
compilation terminated.
Collaborator
|
I do reproduce this error with Rocky Linux 9.6, but using this patch, I end up with another error. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a compilation issue on Rocky Linux 9 by correcting the protobuf binary directory path in CMakeLists.txt from "gen/" to "proto/".
- Updates the PROTO_BINARY_DIR path to match the actual directory where protobuf files are generated
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
8f51e4b to
f916f00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I tried to install catkit2 on Rocky Linux 9 and encountered the following compilation issue:
With the proposed fix, it works now, but I don’t understand how it could compile before.
I hope it doesn’t break things on Windows or other distributions. I hope GitHub Actions will catch any issues.
Cheers,
Arnaud