Skip to content

Update protobuf binary directory path in CMakeLists.txt to avoid a compilation issue on Rocky Linux 9#386

Open
a-sevin wants to merge 1 commit intodevelopfrom
bug/core.pb.cc_not_found
Open

Update protobuf binary directory path in CMakeLists.txt to avoid a compilation issue on Rocky Linux 9#386
a-sevin wants to merge 1 commit intodevelopfrom
bug/core.pb.cc_not_found

Conversation

@a-sevin
Copy link
Copy Markdown
Collaborator

@a-sevin a-sevin commented Sep 19, 2025

Hi,

I tried to install catkit2 on Rocky Linux 9 and encountered the following compilation issue:

      FAILED: [code=1] catkit_core/CMakeFiles/catkit_core.dir/__/proto/core.pb.cc.o
      /usr/bin/g++  -pthread -B /home/micado/miniforge3/envs/catkit2/compiler_compat -DPROTOBUF_USE_DLLS -I/tmp/tmpt925y22a/build/catkit_core -isystem /home/micado/miniforge3/envs/catkit2/include -isystem /home/micado/miniforge3/envs/catkit2/include/eigen3 -O3 -DNDEBUG -fPIC -g -std=gnu++17 -MD -MT catkit_core/CMakeFiles/catkit_core.dir/__/proto/core.pb.cc.o -MF catkit_core/CMakeFiles/catkit_core.dir/__/proto/core.pb.cc.o.d -o catkit_core/CMakeFiles/catkit_core.dir/__/proto/core.pb.cc.o -c /tmp/tmpt925y22a/build/proto/core.pb.cc
      cc1plus: fatal error: /tmp/tmpt925y22a/build/proto/core.pb.cc: No such file or directory
      compilation terminated.

With the proposed fix, it works now, but I don’t understand how it could compile before.

I hope it doesn’t break things on Windows or other distributions. I hope GitHub Actions will catch any issues.

Cheers,
Arnaud

…compilation issue on RockyLinux 9

      FAILED: [code=1] catkit_core/CMakeFiles/catkit_core.dir/__/proto/core.pb.cc.o
      /usr/bin/g++  -pthread -B /home/micado/miniforge3/envs/catkit2/compiler_compat -DPROTOBUF_USE_DLLS -I/tmp/tmpt925y22a/build/catkit_core -isystem /home/micado/miniforge3/envs/catkit2/include -isystem /home/micado/miniforge3/envs/catkit2/include/eigen3 -O3 -DNDEBUG -fPIC -g -std=gnu++17 -MD -MT catkit_core/CMakeFiles/catkit_core.dir/__/proto/core.pb.cc.o -MF catkit_core/CMakeFiles/catkit_core.dir/__/proto/core.pb.cc.o.d -o catkit_core/CMakeFiles/catkit_core.dir/__/proto/core.pb.cc.o -c /tmp/tmpt925y22a/build/proto/core.pb.cc
      cc1plus: fatal error: /tmp/tmpt925y22a/build/proto/core.pb.cc: No such file or directory
      compilation terminated.
@a-sevin a-sevin self-assigned this Sep 19, 2025
@raphaelpclt
Copy link
Copy Markdown
Collaborator

I do reproduce this error with Rocky Linux 9.6, but using this patch, I end up with another error.
I attach the log.
error_log_catkit2.txt

@a-sevin a-sevin requested review from Copilot and ehpor September 20, 2025 22:15
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a compilation issue on Rocky Linux 9 by correcting the protobuf binary directory path in CMakeLists.txt from "gen/" to "proto/".

  • Updates the PROTO_BINARY_DIR path to match the actual directory where protobuf files are generated

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@a-sevin a-sevin force-pushed the bug/core.pb.cc_not_found branch from 8f51e4b to f916f00 Compare September 24, 2025 17:59
@a-sevin a-sevin requested a review from ivalaginja September 26, 2025 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants