Conversation
Collaborator
Author
|
Tests are deadlocking due to #310 not being merged yet. I'll wait for that one before merging this. |
ehpor
force-pushed
the
feature/futex_event
branch
from
2fe7c6d to
07ecb8b
Compare
Collaborator
Author
|
Ready for review but see the caution in the first post. |
Collaborator
Author
|
Nope, the deadlock is still there. I'll have to check this again on Linux. |
Collaborator
Author
|
Regrettably, my inner goldfish prevailed and I forgot to actually implement timeouts for the futex event. That's why it was deadlocking. Now fixed. |
This ensures that the event.wait() has started executing.
According to the docs.
The sleep is 100ms by the pytest.raises() already.
ehpor
force-pushed
the
feature/futex_event
branch
from
32b0e67 to
4c5b598
Compare
Collaborator
Author
|
Rebased after #310 was merged. |
steigersg
approved these changes
May 30, 2025
Contributor
steigersg
left a comment
steigersg
left a comment
There was a problem hiding this comment.
Ran this benchmark on the hicattrois linux machine without issue so seems good
Collaborator
Author
|
@steigersg For reference: what processor? And what Linux version? |
Contributor
Intel Xeon Gold 6242R x 80 Processor and Ubuntu 24.04.2 LTS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
This PR requires #310 to be merged before.
Linux only. There might be a way to do MacOS too, but I remember there being issues with it not having a timeout. There is no way to do this type of synchronization accross processes in Windows, since it only supports intra-process futex.
This PR also adds a test for all (implemented) events, rather than just the default implementation.
Results on AMD Threadripper 5995WX (64 cores). This is the fastest (non-spinlock) synchronization primitive that is implemented on Linux by a full microsecond.
