Draft
Conversation
ehpor
added
enhancement
ehpor
force-pushed
the
feature/conda_installation_of_core
branch
from
d98d2e8 to
4c9be97
Compare
…d update related dependencies
a-sevin
force-pushed
the
feature/conda_installation_of_core
branch
from
4c9be97 to
d254e51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A proposal PR to completely separate out the catkit2-core library into its own directory, not compiled alongside the Python bindings and Python library. This allows it to be distributed separately and be installed as a separate conda package. This allows external repos to more clearly link their own C++ code to the library rather than relying on path hacks.
NOTE: WIP. EXTENDS THE WORK OF #275 AND CURRENTLY BRANCHES OFF FROM THERE.