fix(workerpool-controller): support percentage PDB and hasKey-based template guards#136
Open
kutluhanmetin wants to merge 2 commits intomainfrom
Open
fix(workerpool-controller): support percentage PDB and hasKey-based template guards#136kutluhanmetin wants to merge 2 commits intomainfrom
kutluhanmetin wants to merge 2 commits intomainfrom
Conversation
|
👀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: https://github.com/spacelift-io/kube-workerpool-controller/pull/205
Two related fixes to the PDB feature shipped in #134:
scalesubresource) fromkube-workerpool-controller. Without this, percentage-based PDBs land inSyncFailed: workers.workers.spacelift.io does not implement the scale subresource— the chart-defaultminAvailable: "100%"doesn't enforce its documented semantics.templates/pdb.yaml:{{- if .Values.pdb.maxUnavailable }}(and the symmetricminAvailablecheck, plus the mutually-exclusive guard) treats integer0as false, sopdb.maxUnavailable: 0is silently dropped from the rendered spec. The resulting PDB has neitherminAvailablenormaxUnavailableand gets accepted by Kubernetes but enforces nothing.