refactor(middleware): drop *resolvable.Schema from Exec signature#12
Merged
michieldewilde merged 1 commit intomasterfrom May 7, 2026
Merged
Conversation
The Exec middleware type accepted a *resolvable.Schema parameter that came from internal/exec/resolvable. Because Go forbids importing internal/ packages from outside the module, anyone consuming graphql-go could only define middleware that compiled inside this module - the type they would have to reference wasn't visible to them. The parameter wasn't useful externally either: the schema is fixed for the lifetime of Schema.Exec, so middlewares can't substitute it. Schema.Exec now closes over s.res when wrapping middleware, and the Exec type loses the parameter. This lets downstream code (Spacelift backend in particular) define its own middleware in any package. Built-in middlewares (ParseErrorsMiddleware, InspectInputMiddleware) and the existing TestMiddlewares_In_Exec are updated to match.
peterdeme
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
Execmiddleware type previously included a*resolvable.Schemaparameter sourced frominternal/exec/resolvable. Because Go forbids importinginternal/packages from outside the module, consumers of graphql-go could only define middleware in code that lives inside this module - the type they would have to reference wasn't reachable from anywhere else.