Convert a few simple LEC commands to Toolshed.#43435
Open
VerinSenpai wants to merge 5 commits intospace-wizards:masterfrom
Open
Convert a few simple LEC commands to Toolshed.#43435VerinSenpai wants to merge 5 commits intospace-wizards:masterfrom
VerinSenpai wants to merge 5 commits intospace-wizards:masterfrom
Conversation
PJBot
added
S: Untriaged
VerinSenpai
added
P3: Standard
Contributor
Author
|
Praying for Moony's mercy here 🙏 |
Contributor
Author
|
I see scar put the toolshed locales in a single folder after splitting up the locale file. I will have to follow suit. This will be a shortly maybe tonight verin job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Following Moonys input on my previous command PR, I've converted a chunk of simple to do LEC commands to toolshed.
Command invocation remains the same and most functionality is not lost. I say most because while working on this I noticed the engine NotForServerConsoleError class hardcodes its error message. A ding to my morale to be sure. This is on my todo list.
Technical details
Most of these are one for one. Removed the command name definition from the classes and added the CommandImplementation and ToolshedCommand attirbutes.
Updated locale files to reflect the change to toolshed. Removed help definitions.
Permisisons command file was not following the naming scheme for commands and their files.
OpenPermissionsCommand -> PermissionsCommand
Requirements