Joycontrol configurable by pressing joypad buttons#27
Joycontrol configurable by pressing joypad buttons#27szymor wants to merge 12 commits intosoulfu-dev:masterfrom
Conversation
|
|
||
| #define MAX_JOYSTICK 8 | ||
| #define MAX_JOYSTICK_BUTTON 16 | ||
| #define MAX_JOYSTICK_BUTTON 30 |
There was a problem hiding this comment.
Aaron liked to assign powers of 2, instead of arbitrarily chosen numbers. I have seen in the code there are no explicit dependencies on this fact, but wouldn't it be better to set it to 32? Just a question.
There was a problem hiding this comment.
30 button is enough for controller, set to 32 is not harm, just not necessary, the array to store button will expand 2 slot that doing nothing
| @@ -1,4 +1,4 @@ | |||
| Hauptmen� | |||
| Hauptmen� | |||
There was a problem hiding this comment.
You messed up diactrics. Translations are messed up now!!!
| i = 0 | ||
| while(i < 9) | ||
| if(i < 5) | ||
| key = FileReadByte(file, offset + i + 18) |
There was a problem hiding this comment.
Please leave more comments, as your script implementation looks a bit messy. I double checked whether offsets are correct.
There was a problem hiding this comment.
ah, it use for write offset from 18 to 22 and 24 to 27
| break; | ||
| case SYS_LASTKEYPRESSED: | ||
| i = last_key_pressed; | ||
| if(j == 1) { |
There was a problem hiding this comment.
Please leave comments what j means in this context!
|
okay, i reverted the encoding of translate files |
| i = 0 | ||
| while(i < 9) | ||
| if(i < 5) | ||
| key = FileReadByte(file, offset + i + 18) |
There was a problem hiding this comment.
ah, it use for write offset from 18 to 22 and 24 to 27
| StringAppend(String(0), StringLanguage(3), 256) | ||
| StringAppendNumber(String(0), player+1, 256) | ||
| TitleBar(TRUE, 0.0, -5.5, String(0)) | ||
| TitleBar(FALSE, 0.0, -5.5, String(0)) |
There was a problem hiding this comment.
if you set TRUE, the box of player mapping button can move, it up to u, but i prefer it static
2 participants
Really nice changes that need to be properly re-reviewed. I messed up the review for Miyano :(