Skip to content

Fix music tool.#23

Open
xmeadow wants to merge 1 commit intosoulfu-dev:masterfrom
xmeadow:fix/music-tool-delete
Open

Fix music tool.#23
xmeadow wants to merge 1 commit intosoulfu-dev:masterfrom
xmeadow:fix/music-tool-delete

Conversation

@xmeadow
Copy link
Copy Markdown
Collaborator

@xmeadow xmeadow commented Mar 31, 2026

Added epsilon tolerance to mouse hit detection, fixing #15

Added epsilon tolerance to mouse hit detection, fixing soulfu-dev#15
@szymor
Copy link
Copy Markdown
Collaborator

szymor commented Apr 4, 2026

It partially fixes the issues, but I have a few comments:

  1. how does it actually work? I do not see the reason why the fix fixes anything, still it manages to have some influence on the issue.
  2. When I delete notes, sometimes I delete a single one, and sometimes a whole interconnected row of notes. Both situations can happen with exactly same note positions. (I know it is a slightly different issue than the one in the topic, but still)

I want to test it with a triple mouse button, right now I emulate the middle button by pressing both left and right buttons. After I confirm there are no issues, I will merge it.

Edit: it seems that even without the patch, I am still able to delete notes by using combination left+right buttons. Please wait to confirm the fix when I get a proper 3-button mouse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants