Convert table folder to TypeScript#1251
Conversation
…able-folder' into typescript-migration/migration/table-folder # Conflicts: # benchexec/tablegenerator/react-table/build/main.min.js
| * @typedef {Object} RelevantFilterParam | ||
| * @property {string[]} categoryFilters - The category filters that are currently selected | ||
| * @property {string[]} statusFilters - The status filters that are currently selected | ||
| * @property {string[]} categoryFilterValues - All selectable category filter values | ||
| * @property {string[]} statusFilterValues - All selectable status filter values |
There was a problem hiding this comment.
Is this information still present somewhere?
There was a problem hiding this comment.
Yes, it is now defined as a type:
type RelevantFilterParam = Readonly<{
categoryFilters: ReadonlyArray;
statusFilters: ReadonlyArray;
categoryFilterValues: ReadonlyArray;
statusFilterValues: ReadonlyArray;
}>;
There was a problem hiding this comment.
Sorry, I was not fully clear. I meant the explanations like "The category filters that are currently selected"
There was a problem hiding this comment.
Ah sorry, I overlooked the comments and will add them.
|
Have you finished the review so I can remove the temporary comments? |
Yes, the only thing remaining is re-adding the comments for the filters and removing the migration comments, then we can merge. |
PhilippWendler
merged commit b87dbee
into
typescript-migration/typescript-full-migration
PhilippWendler
deleted the
typescript-migration/migration/table-folder
branch
2 participants
Summary
This pull request migrates the
src/components/Table/folder from JavaScript to TypeScript, improving type safety and maintainability. It includes file conversions, type annotations, and code refactoring for better readability and stricter type checking.Changes
File Conversions:
FilterInputField.js→FilterInputField.tsxMinMaxFilterInputField.js→MinMaxFilterInputField.tsxStatusFilter.js→StatusFilter.tsxindex.js→index.tsRefactors and Cleanups:
hasSameEntriesto useReadonlyArrayfor stricter type safety.FilterInputField.tsx,MinMaxFilterInputField.tsx, andStatusFilter.tsxcomponents.Documentation:
MIGRATION.mdto mark thesrc/components/Table/migration task as complete.