Allow to not specify colors in DMenu.#326
Open
codybloemhard wants to merge 3 commits intosminez:developfrom
Open
Allow to not specify colors in DMenu.#326codybloemhard wants to merge 3 commits intosminez:developfrom
codybloemhard wants to merge 3 commits intosminez:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the user to not specify colours, thus using the default colours of DMenu without having to set them again in Penrose.
Changed all
Colorfields inDMenuConfigtoOption<Color>.This is a breaking change.
I can make it so that it is not a breaking change but the code will be less idiomatic.
It can be done by leaving the fields as type
Colorand instead of checking forSome(color), check if the alpha bits in the colour are not set to 0 before adding the colour flags to DMenu.If you want it like that and not how I did it currently, I'll update it.
The tests have been altered and added to in order to test the new behaviour.