core: add itemtypes datetime and timestamp#772
Merged
Morg42 merged 3 commits intosmarthomeNG:developfrom Apr 1, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds item types
datetime(datetime.datetime object) andtimestamp(POSIX timestamp implemented as float).datetime items have additional methods
item.as_ts()anditem.as_str(format), which output timestamp or text respectively.formatparameter is optional (as for strftime), None means ISO format.timestamp items have additional methods
item.as_dt()anditem.as_str(format), which output datetime or text respectively.formatparameter is optional (as for strftime), None means ISO format.As of now, both types can not be edited in AdminUI as they are not yet implemented there; both will be displayed correctly. I modified the Admin-Module as to enable transferring datetime as JSON (json.encode added the default=str parameter). This might have to be revisited later, as of now, I see no problems.
Feel free to try out and find errors ;) most probably in timezone conversion, though I tried to work with tz-aware datetimes everywhere and get the timezone from shtime.tzinfo().
Oh, and I used
datetimeandtimestampas item type codes; but I'm thinking of changing those todtandtsrespectively. Any opinions on this?closes #421