feat: add RMN deployment changeset#2008
Open
asoliman92 wants to merge 7 commits intoasoliman/rmn-curse-adminsfrom
Open
feat: add RMN deployment changeset#2008asoliman92 wants to merge 7 commits intoasoliman/rmn-curse-adminsfrom
asoliman92 wants to merge 7 commits intoasoliman/rmn-curse-adminsfrom
Conversation
asoliman92
force-pushed
the
asoliman/new-rmn-deployment
branch
from
8b80c61 to
d45c9a7
Compare
asoliman92
commented
Apr 28, 2026
asoliman92
force-pushed
the
asoliman/new-rmn-deployment
branch
from
166fae2 to
af68afa
Compare
|
carte7000
reviewed
Apr 29, 2026
| } | ||
|
|
||
| // CurseRMN curses one or more subjects on an RMN v2.1.0 contract. | ||
| var CurseRMN = changesets.NewFromOnChainSequence(changesets.NewFromOnChainSequenceParams[ |
Contributor
There was a problem hiding this comment.
This should be part of the fast curse adapter like for 1.6.0 or 1.5.0 here: https://github.com/smartcontractkit/chainlink-ccip/blob/6070ed7b58e1fe89c5a2d1aabdc4260ca03ca774/chains/evm/deployment/v1_6_0/adapters/fastcurse.go
carte7000
requested changes
Apr 29, 2026
carte7000
reviewed
Apr 29, 2026
| return c.ChainSel | ||
| } | ||
|
|
||
| var DeployRMN = changesets.NewFromOnChainSequence(changesets.NewFromOnChainSequenceParams[ |
Contributor
Contributor
Author
There was a problem hiding this comment.
I don't think it needs to be part of this PR yet though. The adapter will look very similarly to what we do in evm with some type changes that we can do later.
carte7000
reviewed
Apr 29, 2026
| ChainSel uint64 | ||
| // RMN is an address ref used to look up the deployed RMN contract in the datastore. | ||
| RMN datastore.AddressRef | ||
| Args rmnops.AuthorizedCallerArgs |
Contributor
There was a problem hiding this comment.
If we move this to an adapter we will need to make that field chain agnostic. i.e decouple from any go-ethereum types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.