Handle context cancellations in retry middleware#32
Open
csueiras wants to merge 1 commit intoslok:masterfrom
Open
Handle context cancellations in retry middleware#32csueiras wants to merge 1 commit intoslok:masterfrom
csueiras wants to merge 1 commit intoslok:masterfrom
Conversation
csueiras
force-pushed
the
csueiras/fix-context-cancellation-handling
branch
from
af3cbf3 to
f763913
Compare
muzavan
approved these changes
May 22, 2021
muzavan
reviewed
May 22, 2021
muzavan
left a comment
muzavan
left a comment
There was a problem hiding this comment.
If the feature ended up merged, the behavior upon context.Canceled should be specifically mentioned in the comment (probably on New, or maybe using a flag as part of config).
What do you think?
|
You should also be aware of this basgys@77178d8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31
@slok this changeset just handles the context cancellation within the retry middleware as there's no current way for client code to exit out until the retry attempts are met. I have a use case where I basically want to retry until:
If the context is cancelled pre-execution of the retry middleware the middleware will just continuously retry until the attempts are met (in my use case I basically want to retry forever (math.MaxInt). If the context gets cancelled through a deadline the retrier is unaware of the context cancellation so again it will continue to retry.