serialization: skip ignored files before checking for symlinks#550
Merged
mihaimaruseac merged 1 commit intosigstore:mainfrom Oct 14, 2025
Merged
serialization: skip ignored files before checking for symlinks#550mihaimaruseac merged 1 commit intosigstore:mainfrom
mihaimaruseac merged 1 commit intosigstore:mainfrom
Conversation
spencerschrock
commented
Oct 14, 2025
Comment on lines
+114
to
+119
| if serialization.should_ignore(path, ignore_paths): | ||
| continue | ||
| serialization.check_file_or_directory( | ||
| path, allow_symlinks=self._allow_symlinks | ||
| ) | ||
| if path.is_file() and not serialization.should_ignore( | ||
| path, ignore_paths | ||
| ): | ||
| if path.is_file(): |
Contributor
Author
There was a problem hiding this comment.
I had initially had this as a draft to see if we could use it to test the benchmark harness, but that doesn't support ignore paths
mihaimaruseac
previously approved these changes
Oct 14, 2025
Ignored files aren't serialized, so they shouldn't raise a ValueError if allow_symlinks wasn't set. Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
force-pushed
the
symlink-fix
branch
from
e217a78 to
e898bff
Compare
mihaimaruseac
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ignored files aren't serialized, so they shouldn't raise a ValueError if allow_symlinks wasn't set.
Fixes #549
Checklist