perf: add AliasResolver caching and use batch saves consistently#33
Merged
Soner (shyim) merged 2 commits intomainfrom Feb 2, 2026
Merged
Conversation
- Add resolve cache to AliasResolver to avoid repeated string concatenation - Convert TwigIndexer.indexTwig to use BatchSaveItems - Convert ExtensionIndexer to use BatchSaveItems for bundles and apps - Add benchmarks for AliasResolver.ResolveType Cache hits are ~11x faster than uncached lookups (10ns vs 117ns).
- Add Reset() method to clear resolver state for reuse - Add aliasResolverPool to reuse resolvers across file parses - Use sentinel value for lastNamespace to ensure first Reset() is called - Clear resolveCache when returning resolver to pool
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
AliasResolver Caching (
alias_resolver.go)resolveCachemap to cache resolved type namesnamespace + "\\" + typeName)Batch Saves
SaveItemtoBatchSaveItemsfor twig filesindexBundleandindexAppto useBatchSaveItemsBenchmark Results
Cache hits are ~11x faster than the mixed workload (10ns vs 117ns), with 0 allocations.
Testing
go test ./... golangci-lint runAll tests pass, no lint issues.