Skip to content

feat(account): add deprecation warning for username/password authentication #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Soner (shyim) merged 3 commits into from
Mar 24, 2026
Merged

feat(account): add deprecation warning for username/password authentication #926

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
798b8a0
feat(account): add deprecation warning for username/password authenti…
shyim Mar 24, 2026
b17003a
Update deprecation warning for username/password auth
shyim Mar 24, 2026
27f2faf
Fix typo in deprecation warning message
shyim Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/account-api/login.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ func NewApi(ctx context.Context) (*Client, error) {
password := os.Getenv("SHOPWARE_CLI_ACCOUNT_PASSWORD")

if email != "" && password != "" {
logging.FromContext(ctx).Warnf("authentication with username/password is deprecated and will be removed in future. Please switch to OAuth2 client credentials, see https://developer.shopware.com/docs/products/cli/shopware-account-commands/authentication.html")
return loginWithCredentials(ctx, email, password)
}

Expand Down