Refactor validation logic to use new validation package#624
Merged
Soner (shyim) merged 7 commits intomainfrom Jul 18, 2025
Merged
Refactor validation logic to use new validation package#624Soner (shyim) merged 7 commits intomainfrom
Soner (shyim) merged 7 commits intomainfrom
Conversation
- Updated asset validation functions to utilize the new validation.Check interface and CheckResult struct. - Replaced context-based error handling with a more structured approach using validation results. - Refactored tests to align with the new validation structure, ensuring proper error and result assertions. - Introduced ToolConfigIgnore struct for better management of validation ignores. - Enhanced various verifier implementations (e.g., ESLint, Stylelint, PHPStan) to utilize the new validation results. - Removed deprecated CheckResult struct and constants, centralizing validation logic within the validation package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing
Changes