Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions shop/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -309,12 +309,10 @@ func ReadConfig(fileName string, allowFallback bool) (*Config, error) {
return nil, fmt.Errorf("error while reading included config: %s", err.Error())
}

err = mergo.Merge(additionalConfig, config, mergo.WithOverride, mergo.WithSliceDeepCopy)
err = mergo.Merge(config, additionalConfig, mergo.WithOverride, mergo.WithSliceDeepCopy)
if err != nil {
return nil, fmt.Errorf("error while merging included config: %s", err.Error())
}

config = additionalConfig
}
}

Expand Down
52 changes: 52 additions & 0 deletions shop/config_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
package shop

import (
"os"
"path"
"testing"

"github.com/stretchr/testify/assert"
)

func TestConfigMerging(t *testing.T) {
tmpDir := t.TempDir()

t.Chdir(tmpDir)

baseConfig := []byte(`
admin_api:
client_id: ${SHOPWARE_CLI_CLIENT_ID}
client_secret: ${SHOPWARE_CLI_CLIENT_SECRET}
dump:
where:
customer: "email LIKE '%@nuonic.de' OR email LIKE '%@xyz.com'"
nodata:
- promotion
`)

stagingConfig := []byte(`
url: https://xyz.nuonic.dev
include:
- base.yml
sync:
config:
- settings:
core.store.licenseHost: xyz.nuonic.dev
`)

baseFilePath := path.Join(tmpDir, "base.yml")
stagingFilePath := path.Join(tmpDir, "staging.yml")

assert.NoError(t, os.WriteFile(baseFilePath, baseConfig, 0644))
assert.NoError(t, os.WriteFile(stagingFilePath, stagingConfig, 0644))

config, err := ReadConfig(stagingFilePath, false)
assert.NoError(t, err)

assert.NotNil(t, config.Sync)
assert.NotNil(t, config.Sync.Config)
assert.Len(t, config.Sync.Config, 1)
assert.Equal(t, "xyz.nuonic.dev", config.Sync.Config[0].Settings["core.store.licenseHost"])

assert.NoError(t, os.RemoveAll(tmpDir))
}