Parse Vue expressions for select field to ensure static options with expression values or labels and convert them to option expressions#548
Merged
Soner (shyim) merged 2 commits intoshopware:mainfrom Dec 15, 2025
Conversation
Joshua Behrens (JoshuaBehrens)
force-pushed
the
bugfix/support-expressions-in-select-field
branch
2 times, most recently
from
39228fd to
1f638fb
Compare
Bojan Rajh (bojanrajh)
requested review from
Bojan Rajh (bojanrajh)
and removed request for
Bojan Rajh (bojanrajh)
…Vue-expression values or labels and convert them to option expressions
Soner (shyim)
force-pushed
the
bugfix/support-expressions-in-select-field
branch
from
f77df6b to
f6ef4ca
Compare
Soner (shyim)
approved these changes
Dec 15, 2025
Member
|
Thanks! |
Joshua Behrens (JoshuaBehrens)
deleted the
bugfix/support-expressions-in-select-field
branch
Contributor
Author
|
Thank you for merging :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a reallife test I stumbled upon. As soon as options have expressions either as value or label the fixers generate weird code. This way we can make sure, that even the JSON encoding can support expressions. The uuid approach was just used to reduce conflicts with real code, that has to be converted.
This expects the attribute escaping pull request to be merged.