Upload only changed gist files#1460
Open
Noshkas wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Only changed settings files are included in the Gist update payload when uploading settings, so unchanged files are not re-uploaded and the upload summary reflects the files changed during the upload.
Changes proposed in this pull request:
cloudSettings, while keeping new Gist and force-upload behavior unchanged.GitHubServicetest for partial Gist updates and explicit deletions.Fixes: #508
How Has This Been Tested?
npm run tslint-check && ./node_modules/.bin/tsc -p ./npm run compileGitHubService.UpdateChangedFileswith a minimal VS Code runtime stub.Note: The repository's plain
npm testcommand reaches Mocha after lint/typecheck, but then attempts to load thevscoderuntime module outside the VS Code extension host in this local setup.Screenshots (if appropriate):
N/A
Checklist: