Skip to content

Honor Shakapacker dev server overrides#10

Draft
justin808 wants to merge 13 commits intojg-codex/benchmark-headline-metricsfrom
jg-codex/dev-server-env-overrides
Draft

Honor Shakapacker dev server overrides#10
justin808 wants to merge 13 commits intojg-codex/benchmark-headline-metricsfrom
jg-codex/dev-server-env-overrides

Conversation

@justin808
Copy link
Copy Markdown
Member

@justin808 justin808 commented Apr 15, 2026

Summary

  • make the custom Webpack and Rspack config honor SHAKAPACKER_DEV_SERVER_* overrides like Ruby/Shakapacker
  • document the clean-port local validation workflow after fixing the 3035 asset-proxy mismatch
  • promote the corrected clean-port 8-cycle benchmark as the current headline local result

Validation

  • node --input-type=module ... for default and overridden Shakapacker dev-server ports
  • manual browser verification of /dashboard/inertia_demo and /dashboard/rsc_demo on SHAKAPACKER_DEV_SERVER_PORT=3036
  • curl -k -I https://app.gumroad.dev/packs/js/webpack-runtime.js
  • scripts/perf/measure_dashboard.rb single-run smoke with matching ChromeDriver 147
  • scripts/perf/compare_dashboard_routes.rb corrected clean-port 4-cycle rerun with --reuse-existing
  • scripts/perf/compare_dashboard_routes.rb corrected clean-port 8-cycle rerun

Note

Low Risk
Low risk: small config-loading refactor for dev-server settings plus documentation/perf-note updates; production runtime behavior should be unchanged aside from reading YAML via a shared helper.

Overview
Adds a shared JS loader (config/shakapackerConfig.js) for shakapacker.yml that applies SHAKAPACKER_DEV_SERVER_* environment overrides (with basic type parsing) so both the custom Webpack and Rspack configs stay in sync with Ruby/Shakapacker.

Updates README and performance docs to document the clean-port workflow (e.g., using SHAKAPACKER_DEV_SERVER_PORT=3036) and to promote the corrected clean-port 8-cycle benchmark numbers as the current headline, including notes on the prior 3035 asset-proxy mismatch.

Reviewed by Cursor Bugbot for commit 5a2f0c2. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 15, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5b2d7c7b-787e-4d33-af3b-0d8d60eb0317

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jg-codex/dev-server-env-overrides

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is ON, but it could not run because on-demand usage is turned off. To enable Bugbot Autofix, turn on on-demand usage and set a spend limit in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit de1050d. Configure here.

Comment thread config/shakapackerConfig.js Outdated
…ics' into jg-codex/dev-server-env-overrides

* origin/jg-codex/benchmark-headline-metrics:
  Update demo stack references
  Build test assets before demo specs
  Detect branch-specific demo CI targets
  Disable Spring in demo CI
  Fix demo CI test database bootstrap
  "Update Claude Code Review workflow"
  "Update Claude PR Assistant workflow"
  Fix CI wait for fixture copy service

# Conflicts:
#	README.md
#	docs/current-status.md
#	docs/gumroad-upstream-issue-draft.md
#	docs/performance-team-handoff.md
…server-env-overrides

* jg-codex/benchmark-headline-metrics:
  Keep demo smoke renderer in CI step
…server-env-overrides

* jg-codex/benchmark-headline-metrics:
  Address dashboard demo review findings
…server-env-overrides

* jg-codex/benchmark-headline-metrics:
  Address remaining demo review findings

# Conflicts:
#	README.md
…server-env-overrides

* jg-codex/benchmark-headline-metrics:
  Address dashboard currency review findings
…server-env-overrides

* jg-codex/benchmark-headline-metrics:
  Use purchase currency for activity prices
…server-env-overrides

* jg-codex/benchmark-headline-metrics:
  Fix dashboard demo timezone prop typing
…server-env-overrides

* jg-codex/benchmark-headline-metrics:
  Skip directories in Rspack entry discovery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant