Honor Shakapacker dev server overrides#10
Honor Shakapacker dev server overrides#10justin808 wants to merge 13 commits intojg-codex/benchmark-headline-metricsfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is ON, but it could not run because on-demand usage is turned off. To enable Bugbot Autofix, turn on on-demand usage and set a spend limit in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit de1050d. Configure here.
…ics' into jg-codex/dev-server-env-overrides * origin/jg-codex/benchmark-headline-metrics: Update demo stack references Build test assets before demo specs Detect branch-specific demo CI targets Disable Spring in demo CI Fix demo CI test database bootstrap "Update Claude Code Review workflow" "Update Claude PR Assistant workflow" Fix CI wait for fixture copy service # Conflicts: # README.md # docs/current-status.md # docs/gumroad-upstream-issue-draft.md # docs/performance-team-handoff.md
…server-env-overrides * jg-codex/benchmark-headline-metrics: Keep demo smoke renderer in CI step
…server-env-overrides * jg-codex/benchmark-headline-metrics: Address dashboard demo review findings
…server-env-overrides * jg-codex/benchmark-headline-metrics: Address remaining demo review findings # Conflicts: # README.md
…server-env-overrides * jg-codex/benchmark-headline-metrics: Address dashboard currency review findings
…server-env-overrides * jg-codex/benchmark-headline-metrics: Use purchase currency for activity prices
…server-env-overrides * jg-codex/benchmark-headline-metrics: Fix dashboard demo timezone prop typing
…server-env-overrides * jg-codex/benchmark-headline-metrics: Skip directories in Rspack entry discovery

Summary
SHAKAPACKER_DEV_SERVER_*overrides like Ruby/Shakapacker3035asset-proxy mismatchValidation
node --input-type=module ...for default and overridden Shakapacker dev-server ports/dashboard/inertia_demoand/dashboard/rsc_demoonSHAKAPACKER_DEV_SERVER_PORT=3036curl -k -I https://app.gumroad.dev/packs/js/webpack-runtime.jsscripts/perf/measure_dashboard.rbsingle-run smoke with matchingChromeDriver 147scripts/perf/compare_dashboard_routes.rbcorrected clean-port 4-cycle rerun with--reuse-existingscripts/perf/compare_dashboard_routes.rbcorrected clean-port 8-cycle rerunNote
Low Risk
Low risk: small config-loading refactor for dev-server settings plus documentation/perf-note updates; production runtime behavior should be unchanged aside from reading YAML via a shared helper.
Overview
Adds a shared JS loader (
config/shakapackerConfig.js) forshakapacker.ymlthat appliesSHAKAPACKER_DEV_SERVER_*environment overrides (with basic type parsing) so both the custom Webpack and Rspack configs stay in sync with Ruby/Shakapacker.Updates README and performance docs to document the clean-port workflow (e.g., using
SHAKAPACKER_DEV_SERVER_PORT=3036) and to promote the corrected clean-port8-cycle benchmark numbers as the current headline, including notes on the prior3035asset-proxy mismatch.Reviewed by Cursor Bugbot for commit 5a2f0c2. Bugbot is set up for automated code reviews on this repo. Configure here.