Skip to content

fix: use Rails.error.report in controller rescues for proper error tracking #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seuros merged 1 commit into from
Apr 21, 2026
Merged

fix: use Rails.error.report in controller rescues for proper error tracking #216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/controllers/action_mcp/application_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ def create
result = json_rpc_handler.call(jsonrpc_params)
process_handler_results(result, session, session_initially_missing, is_initialize_request)
rescue StandardError => e
Rails.logger.error "Unified POST Error: #{e.class} - #{e.message}\n#{e.backtrace.join("\n")}"
Rails.error.report(e, handled: true, severity: :error)
id = begin
jsonrpc_params.respond_to?(:id) ? jsonrpc_params.id : nil
rescue StandardError
Expand Down Expand Up @@ -129,7 +129,7 @@ def destroy
Rails.logger.info "Unified DELETE: Terminated session: #{session.id}" if ActionMCP.configuration.verbose_logging
head :no_content
rescue StandardError => e
Rails.logger.error "Unified DELETE: Error terminating session #{session.id}: #{e.class} - #{e.message}"
Rails.error.report(e, handled: true, severity: :error)
render_internal_server_error("Failed to terminate session.")
end
end
Expand Down Expand Up @@ -330,7 +330,7 @@ def authenticate_gateway!
rescue ActionMCP::UnauthorizedError => e
render_unauthorized(e.message)
rescue StandardError => e
Rails.logger.error "Gateway authentication error: #{e.class} - #{e.message}"
Rails.error.report(e, handled: true, severity: :error)
render_unauthorized("Authentication system error")
end
end
Expand Down