vite: Handle error when importing sku render entrypoint#1551
Merged
vite: Handle error when importing sku render entrypoint#1551
vite: Handle error when importing sku render entrypoint#1551Conversation
|
| Name | Type |
|---|---|
| sku | Minor |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
askoufis
commented
Apr 15, 2026
|
|
||
| const { sku } = scopeToFixture('vite-render-error'); | ||
|
|
||
| const filterNodeInternalStackFrames = (stack: string) => |
Contributor
Author
There was a problem hiding this comment.
Node internal stack traces aren't useful and are flaky on CI (see here), so I've filtered them out.
williamlark
reviewed
Apr 15, 2026
williamlark
approved these changes
Apr 15, 2026
Co-authored-by: William Lark <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that there was no stack trace when an error occurs while importing the render entrypoint. This happens before route rendering, so the error handling in #1548 doesn't handle it.
This PR adds error handling for this case.