Skip to content

fix: replace toString with String in switch blocks #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OceanIsEndless wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: replace toString with String in switch blocks #472

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/scratch-vm/src/blocks/scratch3_looks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ class Scratch3LooksBlocks {
target.setCostume(optZeroIndex ? requestedCostume : requestedCostume - 1);
} else {
// Strings should be treated as costume names, where possible
const costumeIndex = target.getCostumeIndexByName(requestedCostume.toString());
const costumeIndex = target.getCostumeIndexByName(String(requestedCostume));

if (costumeIndex !== -1) {
target.setCostume(costumeIndex);
Expand Down Expand Up @@ -426,7 +426,7 @@ class Scratch3LooksBlocks {
stage.setCostume(optZeroIndex ? requestedBackdrop : requestedBackdrop - 1);
} else {
// Strings should be treated as backdrop names where possible
const costumeIndex = stage.getCostumeIndexByName(requestedBackdrop.toString());
const costumeIndex = stage.getCostumeIndexByName(String(requestedBackdrop));

if (costumeIndex !== -1) {
stage.setCostume(costumeIndex);
Expand Down
Loading