You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #(issue)
Type of change
Please remove options that are irrelevant.
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Le score a besoin d'un fonction d'apprentissage
methode learn_score_function(X_train, y_Train, ...) : apprendre la fonction de X (matrice de covariance)
--> cas particulier, dans ce score, il est possible d'apprendre la prédiction ponctuelle également
-> attribut "predictor"
-> au moment du learn_score_function if ! prefit and score.predictor --> learn with score
La méthode marche mieux si on entraîne la matrice de covariance en même temps que le prédicteur (de moyenne), ce qui est le cas dans le code actuel, cf les y_pred dans le fit du score.
Pour intégrer dans MAPIE l'utilisation d'un prédicteur externe pour la moyenne, cela nécessite des changements dans le .fit sur l'objet MAPIE. Ce sera à faire plus tard, après avoir une version qui marche dans le cas où le prédicteur et la matrice sont gérés dans le score.
implémenter get_estimation_distribution
L'API MAPIE produit un intervalle défini par y_low, h_high en régression. Comment généraliser cela en N dimensions ?? Pas du tout trivial pour des formes qui peuvent être n'importe quoi.
Idée : remplacer predict_interval par un predict_ellipse spécifique pour ce score.
Y Mutlivarié : erreur de check_y
--> score a un attribut "multi_output"
--> si c'est le cas _chek_y modifié dans check_fit_parameters
Y univarié : erreur de Pytorch
--> fonction interne au score check_reshape(y) --> vérifie la shape et transforme au besoin.
En fait mis un warning dans ce cas car en pratique si 1D, ne pas utiliser cette classe mais plutôt la version 1D
Autres :
remplacer Any par CovarianceEstimator dans covariance_estimator: Optional[CovarianceEstimator] = None
covariance_trainer.py dans standardized_residuals.py ou utils.py
déplacer contenu test_multi.py dans test_conformity_scores_bounds.py
déplacer contenu test_covariance_trainer.py dans test_conformity_scores_utils.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #(issue)
Type of change
Please remove options that are irrelevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Guidelines
Quality Checks
make lintmake type-checkmake testsmake coveragemake docmake doctestContribution Documentation
LLM Usage
If you used an LLM, please provide the following details: