This repository was archived by the owner on Jun 16, 2022. It is now read-only.
Change geo field from TEXT to MEDIUMTEXT#89
Open
mikesname wants to merge 1 commit intoscholarslab:masterfrom
Open
Change geo field from TEXT to MEDIUMTEXT#89mikesname wants to merge 1 commit intoscholarslab:masterfrom
mikesname wants to merge 1 commit intoscholarslab:masterfrom
Conversation
Geo data such as borders can easily exceed TEXT's 16Kb limit. This also matches the size of the `omeka_element_text.text` column.
Contributor
|
Good point. Thanks so much. I need to get the tests working before I merge it, but I will definitely do so. Thanks |
Author
|
Great. BTW, I ran into this after making a way for our people to add large amounts of geo without having to use the map GUI, so if you're still interesting in a solution for issue #14 I might be able to contribute some code (or, as currently, a separate plugin.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Geo data such as borders can easily exceed TEXT's 16Kb limit. This also matches the size of the
omeka_element_text.textcolumn.