Conversation
|
Okay, we're getting closer. Below a list of what still doesn't work:
Open questions (what's your opinion about that @IRHM?):
|
Book searching is probably good enough for now, if you want to add author searching feel free, though we may need to think about how it will be displayed in the UI since we already have a 'People' filter.
I didn't expect they'd use markdown, I guess we should add parsing to html. I don't mind if you do this in this PR or if we leave it for a later date, since it looks like most authors don't have any formatting for their bio (?), and it's no big deal since we can always add it in in the future. If you do decide to add it in, we should probably add sanitization, like how gomarkdown describes: https://github.com/gomarkdown/markdown?tab=readme-ov-file#sanitize-untrusted-content I haven't looked into it too much, but this library may be better (im basing that off stars and because hugo uses it): https://github.com/yuin/goldmark/ |
Yeah, I don't think it's worth it either, so I'm fine with not adding it. Actually, if searching e.g. "Dan Brown" in the books section, it already returns books by that author, so there's really no need for an additional author search.
I think the book storylines use Markdown, and not the biographies that. Probably mixed that up, sorry. About half of them used Markdown iirc.
Yeah, we should definitely do that. I'll look into the Markdown rendering the coming days (probably tomorrow) |
Changes made
Notes
I'm already opening this to share my progress and hopefully get some feedback if this is going into the right direction or if there's something fundamentally wrong with my logic?
Anyways this took much longer than I expected (already worked more than 6 hours on this), so taking some break now. Not sure when I find time to continue working on this, probably some time next week.
(one day) closes #382
PS: I noticed that the development guide doesn't work, as there's no
servercommand inpackage.json. I've used the steps from the installation instructions now for testing it which worked fine.PPS: I'll remove the
whenlibrary dependency again probably, it doesn't seem like it's able to properly parse the date format fromOpenLibraryanyways.(Note to self: OpenLibrary docs are at https://openlibrary.org/developers/api)