Skip to content

Fix the following error in lib/background.js:#64

Open
doronbehar wants to merge 1 commit intosarahavilov:masterfrom
doronbehar:fix-frames-exclusiveness
Open

Fix the following error in lib/background.js:#64
doronbehar wants to merge 1 commit intosarahavilov:masterfrom
doronbehar:fix-frames-exclusiveness

Conversation

@doronbehar
Copy link
Copy Markdown

Fixes #58, #57, #62 which are all the same.

@doronbehar
Copy link
Copy Markdown
Author

Hey @sarahavilov , Could you please take a look at these? I'd love to spare myself from creating a fork and use it instead.

I'd like to note in this regard that I could not find any alternative at the addons' store which was as extensible / configurable as yours and so beautifully designed (from the technical point of view). So I really see no other choice then hoping to hear back from you! This PR is super simple but I hope we'll see a new release after it because without this fix the extension is useless :)

Thanks!

@reubot
Copy link
Copy Markdown

reubot commented Jun 20, 2019

I'd like to note in this regard that I could not find any alternative at the addons' store which was as extensible / configurable as yours

Have tried https://addons.mozilla.org/en-US/firefox/addon/autofill-quantum/ ?

@doronbehar
Copy link
Copy Markdown
Author

This addon certainly seems good but this one is free software, while the other doesn't seem to be - I couldn't find the source code.

I guess I'll just use my own version of this addon as @sarahavilov seems unavailable..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Doesn't work

2 participants