fix: remove unused --plyr-font-smoothing variable and set default smoothing

[AbdelatefElshafei]

Link to related issue (if applicable)

Fixes #2873

Summary of proposed changes

• Kept the SCSS variable $plyr-font-smoothing and CSS custom property --plyr-font-smoothing so users can override it.
• Updated the plyr-font-smoothing mixin to respect the $mode argument, ensuring that explicit calls like @include plyr-font-smoothing(true) work correctly.
• Default font smoothing is now true (antialiased for webkit, grayscale for Firefox).
• Ensures font smoothing now applies consistently across all elements.

[AbdelatefElshafei]

@sampotts Could you please review this PR? Thanks!

[sampotts]

Ideally, we'd keep the CSS custom property so folks can still set it somehow?

[AbdelatefElshafei]

@sampotts Thanks for the clarification!

Just to confirm — would you prefer keeping the CSS custom property
(--plyr-font-smoothing) but removing the unused SCSS variable only?

I can update the PR so the custom property remains available for users to override,
while still applying the default smoothing value internally.

Let me know and I'll push an update!

[gardiner]

@AbdelatefElshafei Just out of curiosity, could you elaborate on your changes? It looks as if $plyr-font-smoothing is still in the code (you said it should have been removed?). Also I don't get why you are ignoring the method argument $mode in the mixin plyr-font-smoothing()? Thanks for your efforts! Cheers, Ole.

Edit: To clarify, I meant that in your changed code, the mixin plyr-font-smoothing() changes its behavior depending on the setting of the scss variable. If you set $plyr-font-smoothing to false and call plyr-font-smoothing(true), font-smoothing will still be disabled, right?

[AbdelatefElshafei]

@AbdelatefElshafei Just out of curiosity, could you elaborate on your changes? It looks as if $plyr-font-smoothing is still in the code (you said it should have been removed?). Also I don't get why you are ignoring the method argument $mode in the mixin plyr-font-smoothing()? Thanks for your efforts! Cheers, Ole.

Edit: To clarify, I meant that in your changed code, the mixin plyr-font-smoothing() changes its behavior depending on the setting of the scss variable. If you set $plyr-font-smoothing to false and call plyr-font-smoothing(true), font-smoothing will still be disabled, right?

@gardiner Hi Ole,

Thanks a lot for your detailed feedback! You're absolutely right.

I've updated the PR to address your concerns:

The SCSS variable $plyr-font-smoothing is still present as the default, so users can override it via CSS or SCSS.

The mixin plyr-font-smoothing($mode) now respects the $mode argument — calling @include plyr-font-smoothing(true) will enable font smoothing regardless of the default variable.

The default behavior remains consistent, and all elements now apply font smoothing correctly.

This should fix the issue you pointed out about the mixin ignoring the argument.

Thanks again for reviewing — happy to make any further adjustments if needed!

Best,
Abdelatef

[gardiner]

@AbdelatefElshafei Awesome, thank you!

[AbdelatefElshafei]

@AbdelatefElshafei Awesome, thank you!
You are Welcome, Thanks For your FeedBack, Ole!

[AbdelatefElshafei]

@sampotts Can You Take another look i made some changes to make it better

[sampotts]

We should keep the default as false.