fix: ChunkString returns empty slice for empty input (fixes #788)#880
Open
nghiack7 wants to merge 1 commit into
Open
fix: ChunkString returns empty slice for empty input (fixes #788)#880nghiack7 wants to merge 1 commit into
nghiack7 wants to merge 1 commit into
Conversation
ChunkString("", n) was returning [""] (a slice containing one empty
string) because the early-return guard `size >= len(str)` always
fires when str is empty (any positive size satisfies 0 >= 0).
Add an explicit early-return for the empty-string case so that
ChunkString("", n) returns [] consistently with Chunk([]rune{}, n).
Update the existing test case that carried a TODO comment noting this
inconsistency (see samber#788).
Author
|
Friendly ping — this is a one-line fix for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChunkString("", n)was returning[""](a one-element slice containing an empty string) instead of[](an empty slice). This was inconsistent withChunk([]rune{}, n)which correctly returns an empty slice.Root Cause
The early-return guard
if size >= len(str) { return []T{str} }always fires whenstris empty because any positivesizesatisfiessize >= 0. So it returned[]T{""}instead of an empty slice.Fix
Add an explicit early-return for the empty-string case before the size check:
Test
Updated the existing test case (which already carried a
// @TODO: should be []comment referencing #788) to assert the correct behavior.Full test suite passes with no regressions.
Fixes #788