You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This can cause hard to debug issues and is never useful so we should recognize this. Ideally at compile time but comparing type ids at compile time is not yet possible
I do plan to look at this (unless @ibraheemdev or someone of the r-a team beats me to it). I'm just a bit swamped with code reviews across projects, so it may take me until next week to get to it.
Yea no rush, this isn't a feature anyways (and r-a right now can't upgrade since we still need to investigate the fallback immediate cycle handling regression)
would be needed to be detected here. Supertype effectively flattens this variant tree. Thats what we want to guard against here, as that means that salsa will turn a E(B::A(A)) into an E::A(A), so variants lose their meaning if they overlap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can cause hard to debug issues and is never useful so we should recognize this. Ideally at compile time but comparing type ids at compile time is not yet possible