Skip to content

updates to support datastore specific migrations#89

Open
phillipweston wants to merge 2 commits intosailshq:masterfrom
vrmmo:promise_support_for_multi_migrations
Open

updates to support datastore specific migrations#89
phillipweston wants to merge 2 commits intosailshq:masterfrom
vrmmo:promise_support_for_multi_migrations

Conversation

@phillipweston
Copy link
Copy Markdown

@phillipweston phillipweston commented Apr 19, 2019 •
edited
Loading

  • made the migration types functions return promises so we can Promise.all elsewhere
  • made it not require a callback

Phillip Weston added 2 commits April 19, 2019 01:44
update to auto-migrations. now return Promise.resolve() or Promise.re…
46f5cf4 
…ject(err), so that we can Promise.all on the separate migrations for each datastore.
updates to clean up code
eef3cbc
@phillipweston phillipweston mentioned this pull request Apr 19, 2019
Open
@phillipweston
Copy link
Copy Markdown
Author

phillipweston commented Apr 22, 2019

I realize this is broken and that the whole thing needs to be under a single Waterline() instance. Attempted to do that, but had some issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@phillipweston