Advocate Base updates#436
Merged
Jayden Chan (jayden-chan) merged 28 commits intomasterfrom May 12, 2025
Merged
Conversation
ian hitchcock (ianhitchcock)
previously requested changes
May 9, 2025
Contributor
ian hitchcock (ianhitchcock)
left a comment
ian hitchcock (ianhitchcock)
left a comment
There was a problem hiding this comment.
Small change to the impactBrandId type, otherwise just waiting for non prereleases
Contributor
|
Also just flagging that the PR template isn't complete |
Johan Venter (johanventer)
approved these changes
May 12, 2025
Johan Venter (johanventer)
dismissed
ian hitchcock (ianhitchcock)’s stale review
Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Type of change
Links
Checklists
Development
Paperwork
Code review