Skip to content

Tax and cash/fast follows#394

Merged
Sam Beveridge (00salmon) merged 16 commits intomasterfrom
tax-and-cash/fast-follows
May 30, 2025
Merged

Tax and cash/fast follows#394
Sam Beveridge (00salmon) merged 16 commits intomasterfrom
tax-and-cash/fast-follows

Conversation

@zachharrison
Copy link
Copy Markdown
Contributor

Description of the change

Change direction of tooltip to avoid popover from getting cut off.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation or Development tools (readme, specs, tests, code formatting)

Development

  • Prettier was run (if applicable)
  • The behaviour changes in the pull request are covered by specs
  • All tests related to the changed code pass in development

Paperwork

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has a Jira number
  • This pull request has a Process.st launch checklist

Code review

  • Changes have been reviewed by at least one other engineer
  • Security impacts of this change have been considered

Copy link
Copy Markdown
Contributor

@noahwc Noah Clarke (noahwc) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some changelog cleanup!

Copy link
Copy Markdown
Contributor

@00salmon Sam Beveridge (00salmon) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 this looks good to go out whenever, just need Noah Clarke (@noahwc)'s approval

@00salmon
Copy link
Copy Markdown
Contributor

(note to self) update changelog date before launch when we can

@00salmon Sam Beveridge (00salmon) dismissed stale reviews from Noah Clarke (noahwc) and themself via 2e0f033 May 30, 2025 22:28
Copy link
Copy Markdown
Contributor

@00salmon Sam Beveridge (00salmon) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@00salmon Sam Beveridge (00salmon) merged commit 4b08d8f into master May 30, 2025
9 of 11 checks passed
@00salmon Sam Beveridge (00salmon) deleted the tax-and-cash/fast-follows branch May 30, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants