Check for SkParagraph enable status, and pass it to the created engine#939
Open
limitless-brain wants to merge 3 commits intoryanheise:minorfrom
Open
Check for SkParagraph enable status, and pass it to the created engine#939limitless-brain wants to merge 3 commits intoryanheise:minorfrom
limitless-brain wants to merge 3 commits intoryanheise:minorfrom
Conversation
ryanheise
reviewed
May 29, 2022
audio_service/android/src/main/java/com/ryanheise/audioservice/AudioServicePlugin.java
Outdated
Show resolved
Hide resolved
ryanheise
reviewed
May 29, 2022
audio_service/android/src/main/java/com/ryanheise/audioservice/AudioServicePlugin.java
Outdated
Show resolved
Hide resolved
Owner
|
Thanks @limitless-brain for the PR. I'd definitely like to incorporate your contribution. I have left some comments regarding the diff that I'd like you to address before I can review it and see which lines you have actually changed. In addition to those two comments, there are many other locations where formatting changes should be undone before review. |
Author
Noted, I will undo the formatting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check for SkParagraph enable status, and pass it to the created engine bug fix for the issue.