Open
Conversation
|
Great! It seems to solve my problem! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for preserving URL fragments (the part after
#) in deep links when initializing the route inAudioServiceFragmentActivityandAudioServiceActivity.The change involves adding this line:
The modification was made to properly handle deep links containing fragments (e.g.,
https://example.www/web-player#/tv/groups/allChannels/channel/2/)) when the app is launched from a cold state. Previously, the fragment portion of the URL was being dropped during initial route processing, which could break navigation to specific internal locations.The change maintains consistency with how query parameters (the part after
?) are already handled, ensuring all parts of a deep link URL (path, query parameters, and fragment) are properly preserved in the initial route.This fixes an issue where the app would lose the
internalPathportion of deep links when launched from a cold state (when the app wasn't already running).Pre-launch Checklist
minorbranch OR my change is breaking and lands inmajorbranch.pubspec.yamlaccording to the pub versioning philosophy.* DESCRIPTION OF YOUR CHANGE (@your-git-username)).///).dart analyze.dart format.flutter testand all tests are passing.