Add new optional cacheKeyResolver#1005
Open
austinried wants to merge 4 commits intoryanheise:minorfrom
Open
Conversation
Author
|
@ryanheise any thoughts on this API/implementation? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an optional parameter to
AudioService.init()that allows specifying acacheKeyResolverfunction which specifies how a cache key is resolved for a givenMediaItem's art with the cache manager. If no method is specified, the current behavior is kept (the URL is used as the cache key).This new method allow custom cache key implementations to better support situations where the URL may not be suitable as a cache key. It also brings parity with other packages like
cached_network_imagewhich also allows specifying a custom cache key, so if you're using the same cache manager across both libraries you can also use the same cache keys.Fixes #1001.
Pre-launch Checklist
minorbranch OR my change is breaking and lands inmajorbranch.pubspec.yamlaccording to the [pub versioning philosophy].* DESCRIPTION OF YOUR CHANGE (@your-git-username)).///).dart analyze.dart format.flutter testand all tests are passing.