Emphasize hotkeys in footer with color#2381
Open
senekor wants to merge 1 commit intorust-lang:mainfrom
Open
Conversation
Contributor
|
I love it! Since the colors are essential here, did you check whether they are fine for color-blindness? |
Contributor
|
Maybe also make it bold? |
senekor
force-pushed
the
senekor/soqukxyvzplr
branch
from
38b1d20 to
c59ef64
Compare
Contributor
Author
Not really. It's the same color is the "PENDING" marker in the list of exercises. Also, the user controls the actual colors that are being rendered via their terminal theme / configuration. So, if somebody can't see yellow, presumably they already configured their terminal to render something that's better visible to them.
Good idea! Done. Btw. do you prefer clean history or never force-pushing for PRs? My default is to amend and force-push, but I can do what's more pleasant for you to review. |
senekor
force-pushed
the
senekor/soqukxyvzplr
branch
2 times, most recently
from
c3cee06 to
85b6e70
Compare
senekor
force-pushed
the
senekor/soqukxyvzplr
branch
from
85b6e70 to
03c5baf
Compare
Contributor
Author
|
updated screenshots with boldness: 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I find this nicer to read than the angle bracket emphasis:
This is how it looks with a filter activated: