Calculate Jacobians with forward AD from num-dual#30
Open
prehner wants to merge 1 commit intorust-cv:mainfrom
Open
Calculate Jacobians with forward AD from num-dual#30prehner wants to merge 1 commit intorust-cv:mainfrom
prehner wants to merge 1 commit intorust-cv:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
this is in reference to #24 . Jacobians are calculated using forward mode automatic differentiation provided by the
num-dualcrate. The user only needs to implement the residuals using theDualNumtrait bound, everything else comes for free (implementation-wise). Because, with AD the residuals and Jacobians are always evaluated simultaneously, I simplified the interface for theLeastSquaresProblemADa bit compared to theLeastSquaresProblemtrait. Also,num-dualuses theOwneddata storage innalgebra, so this is also hardcoded here, but might be relaxed if that is necessary.To validate, I adapted the line fitting example in
tests. This is still a bit raw and I am happy to clean it up and document it properly if you are interested in having this feature.