ExpenseReportsController#create: avoid destroying existing report#146
Merged
ExpenseReportsController#create: avoid destroying existing report#146
Conversation
build_expense_report on a has_one with dependent: :destroy deletes the existing record (cascading to line_items and submissions) before inserting. The RecordNotUnique rescue never fires because the old row is already gone. Check for an existing report first, and use ExpenseReport.create! directly to bypass has_one replacement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build_expense_reporton ahas_onewithdependent: :destroydeletes the existing record (cascading to line_items and submissions) before inserting. TheRecordNotUniquerescue never fires because the old row is already gone. Check for an existing report first, and useExpenseReport.create!directly to bypasshas_onereplacement.