fix(init): make --agent cursor truly standalone (#213)#1840
Open
pszymkowiak wants to merge 1 commit into
Open
Conversation
`rtk init -g --agent cursor` still tried to write ~/.claude/RTK.md
because install_claude was derived from `!opencode` only, ignoring the
explicit non-Claude agent selection. Users with no prior Claude Code
install hit:
Failed to write RTK.md: ~/.claude/RTK.md: No such file or directory
Fix:
- Route install_claude through a `should_install_claude(opencode, agent)`
helper so `--agent cursor|windsurf|cline|kilocode|antigravity` skips
the Claude artifacts (RTK.md, CLAUDE.md patch, settings.json hook).
`--agent claude` and no-agent default continue to install Claude.
- Have `patch_cursor_hooks_json` create `~/.cursor/` on demand so
Cursor-only users without that directory don't fail.
Tests:
- `test_should_install_claude_routing`: exhaustive matrix over
(opencode, agent) combinations.
- `test_patch_cursor_hooks_json_creates_missing_parent_dir`: regression
guard ensuring the parent directory is auto-created.
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
|
patrick seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rtk init -g --agent cursorno longer attempts to install Claude Code artifacts (RTK.md, CLAUDE.md patch, settings.json hook).~/.cursor/is now auto-created when missing, so Cursor-only users without a prior config directory don't crash.Context
Issue #213 originally asked for Cursor support. PR #595 added
--agent cursor(merged 2026-03-18), but the routing logic keptinstall_claude = !opencode, ignoring the explicit--agentselection. Cursor-only users hit:```
rtk: Failed to write RTK.md: ~/.claude/RTK.md: Failed to create temp file in ~/.claude: No such file or directory (os error 2)
```
Reported in issue #213 by @ayhangokhan and re-confirmed by @cgondrovic-servpro ("why is it referencing anything claude related?").
Changes
Test plan
/.cursor/hooks.json` created, no `/.claude/` files./.claude` first → exit 0, `/.claude/` left untouched.Closes #213.
🤖 Generated with Claude Code