Skip to content

[experiment] Special handling of root node in AcyclicGraph algorithm #22014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ppedrot wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

[experiment] Special handling of root node in AcyclicGraph algorithm #22014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
762f673
Allow setting a root in AcyclicGraph.
ppedrot Mar 28, 2026
b4fa024
Keep track of components in AcyclicGraph data structure.
ppedrot Mar 28, 2026
8cb7c29
Remove root from AcyclicGraph internal graph.
ppedrot Mar 30, 2026
e487b6c
Temporarily tweak the test-suite.
ppedrot May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions kernel/qGraph.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ module G = AcyclicGraph.Make(struct

let equal = Quality.equal
let compare = Quality.compare
let root = None

let raw_pr = Quality.raw_pr

Expand Down
7 changes: 2 additions & 5 deletions kernel/uGraph.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module G = AcyclicGraph.Make(struct

let equal = Level.equal
let compare = Level.compare
let root = Some Level.set

let raw_pr = Level.raw_pr

Expand Down Expand Up @@ -84,11 +85,7 @@ let empty_universes = {
above_prop_qvars=Sorts.QVar.Set.empty;
}

let initial_universes =
let big_rank = 1000000 in
let g = G.empty in
let g = G.add ~rank:big_rank Level.set g in
{empty_universes with graph=g}
let initial_universes = empty_universes

let initial_universes_with g = {g with graph=initial_universes.graph}

Expand Down
Loading
Loading