[experiment] Convert stack in the right order except for application nodes.#21996
Draft
ppedrot wants to merge 2 commits into
Draft
[experiment] Convert stack in the right order except for application nodes.#21996ppedrot wants to merge 2 commits into
ppedrot wants to merge 2 commits into
Conversation
Member
Author
|
@coqbot bench |
Contributor
|
hott is going mad on this command https://github.com/HoTT/Coq-HoTT/blob/0fa55b36710d8a6933ea4f965f7adc5fc0377318/theories/Homotopy/ExactSequence.v#L471-L475 |
Contributor
|
🏁 Bench results: INFO: failed to install coq-vst (dependency coq-compcert failed) 🐢 Top 25 slow downs┌─────────────────────────────────────────────────────────────────────────────────────────────────────────┐ │ TOP 25 SLOW DOWNS │ │ │ │ OLD NEW DIFF %DIFF Ln FILE │ ├─────────────────────────────────────────────────────────────────────────────────────────────────────────┤ │ 0.0559 7096 7095.7910 12703039.87% 471 coq-hott/theories/Homotopy/ExactSequence.v.html │ │ 0.00598 44.8 44.7997 749408.87% 4836 rocq-mathcomp-algebra/algebra/matrix.v.html │ │ 0.00650 44.6 44.6110 686640.63% 4866 rocq-mathcomp-algebra/algebra/matrix.v.html │ │ 0.00658 36.1 36.0531 547918.81% 4832 rocq-mathcomp-algebra/algebra/matrix.v.html │ │ 0.00167 35.9 35.8640 2150119.60% 397 coq-fourcolor/theories/proof/gridmap.v.html │ │ 0.00724 35.7 35.7077 493336.52% 4863 rocq-mathcomp-algebra/algebra/matrix.v.html │ │ 0.00152 27.2 27.1844 1783755.31% 461 coq-fourcolor/theories/proof/walkup.v.html │ │ 0.00553 27.0 26.9583 487227.74% 452 coq-fourcolor/theories/proof/walkup.v.html │ │ 0.00618 26.9 26.8490 434238.96% 451 coq-fourcolor/theories/proof/walkup.v.html │ │ 1.15 24.5 23.3722 2033.55% 1588 coq-mathcomp-analysis/theories/ftc.v.html │ │ 0.000501 11.5 11.5452 2304421.76% 753 coq-unimath/UniMath/AlgebraicTheories/Combinators.v.html │ │ 0.828 12.3 11.4670 1384.08% 105 coq-mathcomp-analysis/theories/gauss_integral.v.html │ │ 0.283 7.59 7.3089 2586.47% 1061 coq-mathcomp-odd-order/theories/PFsection13.v.html │ │ 0.183 7.44 7.2601 3977.13% 778 coq-mathcomp-analysis/theories/hoelder.v.html │ │ 0.336 6.58 6.2433 1860.22% 1263 coq-mathcomp-analysis/theories/ftc.v.html │ │ 0.00190 6.17 6.1638 324242.14% 240 coq-fourcolor/theories/proof/birkhoff.v.html │ │ 0.311 6.42 6.1074 1963.80% 1538 coq-mathcomp-analysis/theories/ftc.v.html │ │ 0.00233 6.04 6.0364 259519.00% 220 coq-fourcolor/theories/proof/birkhoff.v.html │ │ 0.0159 5.82 5.8037 36425.37% 139 coq-mathcomp-analysis/theories/derive.v.html │ │ 0.593 6.33 5.7411 967.75% 1153 coq-mathcomp-analysis/theories/ftc.v.html │ │ 0.450 5.81 5.3617 1191.45% 361 coq-mathcomp-analysis/theories/gauss_integral.v.html │ │ 0.519 5.31 4.7874 922.76% 1170 coq-mathcomp-analysis/theories/ftc.v.html │ │ 0.519 5.30 4.7810 921.52% 1161 coq-mathcomp-analysis/theories/ftc.v.html │ │ 0.420 5.02 4.6039 1094.98% 1665 coq-mathcomp-analysis/theories/ftc.v.html │ │ 0.407 4.91 4.5026 1106.17% 622 coq-mathcomp-analysis/theories/ftc.v.html │ └─────────────────────────────────────────────────────────────────────────────────────────────────────────┘ 🐇 Top 25 speed ups┌─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐ │ TOP 25 SPEED UPS │ │ │ │ OLD NEW DIFF %DIFF Ln FILE │ ├─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤ │ 8.92 0.0325 -8.8911 -99.64% 126 coq-mathcomp-odd-order/theories/BGappendixAB.v.html │ │ 2.84 0.426 -2.4184 -85.01% 404 coq-mathcomp-odd-order/theories/BGappendixC.v.html │ │ 2.09 0.643 -1.4458 -69.23% 459 coq-unimath/UniMath/ModelCategories/Examples.v.html │ │ 94.6 93.3 -1.2486 -1.32% 999 coq-performance-tests-lite/src/fiat_crypto_via_setoid_rewrite_standalone.v.html │ │ 1.38 0.163 -1.2149 -88.15% 150 coq-mathcomp-odd-order/theories/BGappendixAB.v.html │ │ 1.43 0.263 -1.1695 -81.65% 395 coq-mathcomp-odd-order/theories/BGappendixC.v.html │ │ 1.48 0.315 -1.1687 -78.77% 396 coq-mathcomp-odd-order/theories/BGappendixC.v.html │ │ 94.5 93.3 -1.1536 -1.22% 968 coq-performance-tests-lite/src/fiat_crypto_via_setoid_rewrite_standalone.v.html │ │ 1.48 0.347 -1.1332 -76.56% 368 coq-unimath/UniMath/ModelCategories/Examples.v.html │ │ 1.42 0.329 -1.0959 -76.91% 918 coq-mathcomp-odd-order/theories/PFsection12.v.html │ │ 1.46 0.470 -0.9868 -67.72% 158 coq-mathcomp-analysis/theories/realfun.v.html │ │ 1.11 0.128 -0.9849 -88.46% 659 coq-mathcomp-analysis/theories/independence.v.html │ │ 0.711 0.00296 -0.7079 -99.58% 524 coq-mathcomp-analysis/theories/lebesgue_integral_theory/lebesgue_integral_differentiation.v.html │ │ 0.710 0.127 -0.5828 -82.07% 642 coq-mathcomp-analysis/theories/probability_theory/random_variable.v.html │ │ 0.624 0.0459 -0.5782 -92.65% 624 coq-mathcomp-odd-order/theories/BGsection13.v.html │ │ 203 203 -0.5699 -0.28% 8 coq-neural-net-interp-computed-lite/theories/MaxOfTwoNumbersSimpler/Computed/AllLogits.v.html │ │ 0.571 0.00196 -0.5690 -99.66% 160 coq-unimath/UniMath/CategoryTheory/Monoidal/RezkCompletion/LiftedAssociator.v.html │ │ 0.636 0.122 -0.5135 -80.74% 593 coq-mathcomp-analysis/theories/ftc.v.html │ │ 0.638 0.125 -0.5132 -80.41% 570 coq-mathcomp-analysis/theories/ftc.v.html │ │ 0.550 0.0456 -0.5047 -91.71% 592 coq-mathcomp-analysis/theories/lebesgue_integral_theory/lebesgue_integral_nonneg.v.html │ │ 0.552 0.0656 -0.4861 -88.11% 313 coq-fourcolor/theories/proof/revsnip.v.html │ │ 1.36 0.887 -0.4725 -34.75% 408 rocq-stdlib/theories/MSets/MSetAVL.v.html │ │ 1.27 0.799 -0.4724 -37.15% 151 coq-mathcomp-odd-order/theories/BGappendixAB.v.html │ │ 46.4 46.0 -0.4689 -1.01% 115 coq-bedrock2/bedrock2/src/bedrock2Examples/full_mul.v.html │ │ 0.517 0.0593 -0.4578 -88.53% 526 coq-mathcomp-odd-order/theories/PFsection9.v.html │ └─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘ |
Variant of rocq-prover#19038 that was itself a revival of another endless stream of attempts at making the kernel conversion saner.
43a03c3 to
111c890
Compare
Member
Author
Contributor
|
🏁 Bench results: INFO: failed to install coq-vst (dependency coq-compcert failed) 🐢 Top 25 slow downs┌─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐ │ TOP 25 SLOW DOWNS │ │ │ │ OLD NEW DIFF %DIFF Ln FILE │ ├─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤ │ 0.163 4.48 4.3124 2651.41% 536 coq-unimath/UniMath/CategoryTheory/LocallyCartesianClosed/Preservation.v.html │ │ 0.0398 2.18 2.1368 5368.04% 452 coq-unimath/UniMath/CategoryTheory/LocallyCartesianClosed/Preservation.v.html │ │ 200 202 1.6524 0.82% 8 coq-neural-net-interp-computed-lite/theories/MaxOfTwoNumbersSimpler/Computed/AllLogits.v.html │ │ 94.6 95.3 0.6548 0.69% 968 coq-performance-tests-lite/src/fiat_crypto_via_setoid_rewrite_standalone.v.html │ │ 3.73 4.27 0.5403 14.49% 492 rocq-stdlib/theories/Reals/Cauchy/ConstructiveCauchyRealsMult.v.html │ │ 0.159 0.629 0.4693 294.49% 301 coq-unimath/UniMath/CategoryTheory/LocallyCartesianClosed/Preservation.v.html │ │ 0.0351 0.466 0.4313 1227.14% 373 coq-unimath/UniMath/CategoryTheory/LocallyCartesianClosed/Preservation.v.html │ │ 2.28 2.69 0.4149 18.23% 212 rocq-stdlib/theories/setoid_ring/Ncring_tac.v.html │ │ 36.3 36.7 0.4012 1.10% 139 coq-fiat-parsers/src/Parsers/Refinement/SharpenedJSON.v.html │ │ 0.632 1.01 0.3821 60.50% 200 rocq-stdlib/theories/Numbers/HexadecimalNat.v.html │ │ 0.000749 0.382 0.3813 50906.54% 146 coq-mathcomp-analysis/theories/lebesgue_integral_theory/lebesgue_integral_monotone_convergence.v.html │ │ 94.7 95.0 0.3491 0.37% 999 coq-performance-tests-lite/src/fiat_crypto_via_setoid_rewrite_standalone.v.html │ │ 38.2 38.5 0.3485 0.91% 224 coq-performance-tests-lite/PerformanceExperiments/rewrite_lift_lets_map.v.html │ │ 0.0164 0.362 0.3457 2104.13% 251 coq-unimath/UniMath/CategoryTheory/Inductives/Lists.v.html │ │ 0.204 0.541 0.3366 164.67% 374 rocq-stdlib/theories/Sorting/SetoidList.v.html │ │ 0.408 0.738 0.3297 80.80% 1161 rocq-stdlib/theories/Strings/Byte.v.html │ │ 38.8 39.1 0.3215 0.83% 236 coq-rewriter/src/Rewriter/Rewriter/Examples/PerfTesting/LiftLetsMap.v.html │ │ 0.351 0.641 0.2905 82.85% 596 rocq-stdlib/theories/Strings/Byte.v.html │ │ 2.80 3.08 0.2831 10.11% 597 coq-unimath/UniMath/CategoryTheory/DisplayedCats/Examples/SetGroupoidComprehension.v.html │ │ 18.7 19.0 0.2697 1.44% 481 coq-verdi-raft/theories/RaftProofs/EndToEndLinearizability.v.html │ │ 7.51 7.78 0.2659 3.54% 602 coq-unimath/UniMath/CategoryTheory/EnrichedCats/Limits/Examples/StructureEnrichedLimits.v.html │ │ 0.228 0.490 0.2613 114.40% 4 rocq-stdlib/theories/extraction/ExtrHaskellZInteger.v.html │ │ 0.491 0.742 0.2512 51.19% 59 rocq-stdlib/theories/ZArith/Zeuclid.v.html │ │ 0.255 0.499 0.2444 95.97% 1 rocq-stdlib/theories/micromega/ZifyPow.v.html │ │ 0.728 0.967 0.2395 32.91% 41 rocq-stdlib/theories/ZArith/Zdiv_facts.v.html │ └─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘ 🐇 Top 25 speed ups┌──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐ │ TOP 25 SPEED UPS │ │ │ │ OLD NEW DIFF %DIFF Ln FILE │ ├──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤ │ 2.11 0.642 -1.4683 -69.59% 459 coq-unimath/UniMath/ModelCategories/Examples.v.html │ │ 13.1 12.1 -1.0518 -8.01% 388 coq-unimath/UniMath/CategoryTheory/Hyperdoctrines/PartialEqRels/Logic/Existential.v.html │ │ 13.5 12.6 -0.9426 -6.97% 930 coq-unimath/UniMath/CategoryTheory/Hyperdoctrines/PartialEqRels/ExponentialEqs.v.html │ │ 13.1 12.2 -0.9250 -7.07% 324 coq-unimath/UniMath/CategoryTheory/Hyperdoctrines/PartialEqRels/Logic/Existential.v.html │ │ 9.18 8.44 -0.7406 -8.06% 648 coq-unimath/UniMath/CategoryTheory/Hyperdoctrines/PartialEqRels/ExponentialEqs.v.html │ │ 8.53 7.83 -0.6949 -8.15% 633 coq-unimath/UniMath/CategoryTheory/Hyperdoctrines/PartialEqRels/Logic/Existential.v.html │ │ 7.91 7.32 -0.5946 -7.52% 663 coq-unimath/UniMath/CategoryTheory/Hyperdoctrines/PartialEqRels/ExponentialEqs.v.html │ │ 9.41 8.84 -0.5649 -6.00% 950 coq-unimath/UniMath/CategoryTheory/Hyperdoctrines/PartialEqRels/ExponentialEqs.v.html │ │ 10.1 9.66 -0.4577 -4.53% 435 coq-mathcomp-odd-order/theories/PFsection12.v.html │ │ 4.38 3.95 -0.4287 -9.80% 196 rocq-stdlib/theories/ZArith/ZModOffset.v.html │ │ 7.17 6.75 -0.4180 -5.83% 831 coq-unimath/UniMath/CategoryTheory/Hyperdoctrines/PartialEqRels/ExponentialEqs.v.html │ │ 19.8 19.4 -0.4068 -2.06% 559 coq-mathcomp-odd-order/theories/PFsection9.v.html │ │ 0.891 0.493 -0.3974 -44.62% 586 rocq-stdlib/theories/Strings/Byte.v.html │ │ 5.03 4.65 -0.3820 -7.60% 646 coq-unimath/UniMath/CategoryTheory/Hyperdoctrines/PartialEqRels/Logic/Existential.v.html │ │ 0.642 0.268 -0.3738 -58.23% 12 rocq-stdlib/theories/MSets/MSets.v.html │ │ 0.342 0.00134 -0.3409 -99.61% 265 coq-mathcomp-analysis/theories/lebesgue_integral_theory/lebesgue_integral_nonneg.v.html │ │ 0.700 0.423 -0.2766 -39.54% 682 rocq-stdlib/theories/Numbers/DecimalFacts.v.html │ │ 3.56 3.29 -0.2719 -7.64% 751 coq-unimath/UniMath/CategoryTheory/Hyperdoctrines/PartialEqRels/ExponentialEqs.v.html │ │ 0.405 0.136 -0.2692 -66.52% 1177 rocq-stdlib/theories/Reals/Abstract/ConstructiveReals.v.html │ │ 4.05 3.79 -0.2605 -6.43% 909 coq-unimath/UniMath/CategoryTheory/Hyperdoctrines/PartialEqRels/ExponentialEqs.v.html │ │ 4.08 3.83 -0.2543 -6.23% 895 coq-unimath/UniMath/CategoryTheory/Hyperdoctrines/PartialEqRels/ExponentialEqs.v.html │ │ 3.28 3.03 -0.2518 -7.67% 668 coq-unimath/UniMath/CategoryTheory/Hyperdoctrines/PartialEqRels/Logic/Existential.v.html │ │ 3.50 3.25 -0.2504 -7.15% 610 coq-unimath/UniMath/CategoryTheory/Hyperdoctrines/PartialEqRels/ExponentialEqs.v.html │ │ 10.2 9.95 -0.2470 -2.42% 673 coq-rewriter/src/Rewriter/Rewriter/Wf.v.html │ │ 21.0 20.8 -0.2442 -1.16% 479 rocq-metarocq-erasure/erasure/theories/EWcbvEvalCstrsAsBlocksFixLambdaInd.v.html │ └──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Variant of #19038 that was itself a revival of another endless stream of attempts at making the kernel conversion saner.