Skip to content

fix #807: add --packet-encoding option to roc-send #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ayoub-glitsh wants to merge 1 commit into from
Closed

fix #807: add --packet-encoding option to roc-send #834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/tools/roc_send/cmdline.ggo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ section "Options"
option "rate" - "Override input sample rate, Hz"
int optional

option "packet-encoding" - "Register custom packet encoding (e.g. \"96:s16/48000/stereo\")"
typestr="ENCODING" string optional

option "latency-backend" - "Which latency to use in latency tuner"
values="niq" default="niq" enum optional

Expand Down
17 changes: 17 additions & 0 deletions src/tools/roc_send/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
#include "roc_node/context.h"
#include "roc_node/sender.h"
#include "roc_pipeline/sender_sink.h"
#include "roc_rtp/encoding.h"
#include "roc_sndio/backend_dispatcher.h"
#include "roc_sndio/backend_map.h"
#include "roc_sndio/print_supported.h"
Expand Down Expand Up @@ -268,6 +269,22 @@ int main(int argc, char** argv) {
return 1;
}

if (args.packet_encoding_given) {
rtp::Encoding enc;
if (!rtp::parse_encoding(args.packet_encoding_arg, enc)) {
roc_log(LogError,
"invalid --packet-encoding: bad format,"
" expected \"<id>:<format>/<rate>/<channels>\","
" e.g. \"96:s16/48000/stereo\"");
return 1;
}
if (!context.encoding_map().add_encoding(enc)) {
roc_log(LogError, "invalid --packet-encoding: failed to register encoding");
return 1;
}
sender_config.payload_type = enc.payload_type;
}

sndio::BackendDispatcher backend_dispatcher(context.arena());
if (args.list_supported_given) {
if (!address::print_supported(context.arena())) {
Expand Down
Loading