Skip to content

Security: Outbound HTTP request at import time without timeout#2239

Open
tomaioo wants to merge 1 commit intoroboflow:mainfrom
tomaioo:fix/security/outbound-http-request-at-import-time-wit
Open

Security: Outbound HTTP request at import time without timeout#2239
tomaioo wants to merge 1 commit intoroboflow:mainfrom
tomaioo:fix/security/outbound-http-request-at-import-time-wit

Conversation

@tomaioo
Copy link
Copy Markdown

@tomaioo tomaioo commented Apr 17, 2026

Summary

Security: Outbound HTTP request at import time without timeout

Problem

Severity: Low | File: inference/core/__init__.py:L20

The package performs a network call to GitHub during import/version check and does not set a timeout. This can block startup indefinitely in constrained networks and can be abused for availability degradation (slow or hung connections).

Solution

Set a short timeout (e.g., requests.get(..., timeout=3)) and ensure failures are non-blocking. Consider deferring the check to a background task only.

Changes

  • inference/core/__init__.py (modified)

The package performs a network call to GitHub during import/version check and does not set a timeout. This can block startup indefinitely in constrained networks and can be abused for availability degradation (slow or hung connections).

Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants