Security: Outbound HTTP request at import time without timeout#2239
Open
tomaioo wants to merge 1 commit intoroboflow:mainfrom
Open
Security: Outbound HTTP request at import time without timeout#2239tomaioo wants to merge 1 commit intoroboflow:mainfrom
tomaioo wants to merge 1 commit intoroboflow:mainfrom
Conversation
The package performs a network call to GitHub during import/version check and does not set a timeout. This can block startup indefinitely in constrained networks and can be abused for availability degradation (slow or hung connections). Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Outbound HTTP request at import time without timeout
Problem
Severity:
Low| File:inference/core/__init__.py:L20The package performs a network call to GitHub during import/version check and does not set a timeout. This can block startup indefinitely in constrained networks and can be abused for availability degradation (slow or hung connections).
Solution
Set a short timeout (e.g.,
requests.get(..., timeout=3)) and ensure failures are non-blocking. Consider deferring the check to a background task only.Changes
inference/core/__init__.py(modified)