Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #418 +/- ##
==========================================
+ Coverage 56.96% 56.99% +0.03%
==========================================
Files 55 55
Lines 10680 10683 +3
==========================================
+ Hits 6084 6089 +5
+ Misses 4164 4163 -1
+ Partials 432 431 -1
Continue to review full report at Codecov.
|
rjkroege
requested changes
Jan 20, 2022
Owner
rjkroege
left a comment
rjkroege
left a comment
There was a problem hiding this comment.
w.r.t. e286f0a
- ecmd.go:160:
toOEBand its invokees seem complicated for what it does. (This was true before your change. It's just odd.) - ecmd.go:164: once your changes to make
bmore useful are done, we will probably discover thatcurtextis getting set incorrectly in numerous places. Sigh.
This patch seems fine except for (as you noted) the absence of tests. Please add some tests? Do you want to address the discussion in #237 in this PR or land this first and then address that?
camsn0w
force-pushed
the
more_useful_b
branch
from
e286f0a to
83964ab
Compare
camsn0w
force-pushed
the
more_useful_b
branch
from
83964ab to
b90ae5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #237 by making it possible to use a regex instead of an exact filename.