Remove default shfmt flags to respect .editorconfig file#8
Open
tolkonepiu wants to merge 1 commit intoreviewdog:mainfrom
Open
Remove default shfmt flags to respect .editorconfig file#8tolkonepiu wants to merge 1 commit intoreviewdog:mainfrom
shfmt flags to respect .editorconfig file#8tolkonepiu wants to merge 1 commit intoreviewdog:mainfrom
Conversation
The default `shfmt` flags `-i 2 -ci` have been removed to allow `shfmt` to respect the `.editorconfig` file when formatting shell scripts. When default flags are specified, `shfmt` ignores the settings in `.editorconfig`, which can lead to inconsistencies in formatting. By setting the default to an empty string, users can now rely on `.editorconfig` for formatting configurations, or override the flags as needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default
shfmtflags-i 2 -cihave been removed to allowshfmtto respect the.editorconfigfile when formatting shell scripts.When default flags are specified,
shfmtignores the settings in.editorconfig, which can lead to inconsistencies in formatting. By setting the default to an empty string, users can now rely on.editorconfigfor formatting configurations, or override the flags as needed.