Skip to content

feat: Enhance layout editor with matrix editing, index display, and key insertion#920

Merged
yoichiro merged 1 commit intomainfrom
feature/workbench-layout-editor-enhancements
Apr 5, 2026
Merged

feat: Enhance layout editor with matrix editing, index display, and key insertion#920
yoichiro merged 1 commit intomainfrom
feature/workbench-layout-editor-enhancements

Conversation

@yoichiro
Copy link
Copy Markdown
Collaborator

@yoichiro yoichiro commented Apr 5, 2026

Summary

  • Matrix position editor on keycaps: Selected keys show ▲▼◀▶ arrows to change row/col values. Arrows skip to nearest available position to prevent duplicates.
  • Layout index display: Each keycap shows its layout array index (0, 1, 2...) so users can see the keymap.c correspondence.
  • Key insertion with index: Add Key dialog now includes an Index field to insert keys at specific positions, shifting existing keys. Defaults: index=keyCount (append), row/col=max+1.
  • Remove undo/redo: Removed since it was incompatible with 2-way binding auto-apply.
  • Add Japanese translations for new UI labels.

Test plan

  • Select a key → verify ▲▼◀▶ arrows appear with row,col display
  • Click ▶ → verify col jumps to nearest available value (skipping occupied)
  • Click ▲ → verify row decreases to nearest available value (min 0)
  • Verify all keycaps show layout index numbers (0, 1, 2...)
  • Click Add Key → verify Index field with default=keyCount, Row/Col default=max+1
  • Add key at index 0 → verify it inserts at beginning and other keys shift
  • Add key at last index → verify it appends at end
  • Verify matrix changes persist after switching to Code Editor and back
  • Verify Undo/Redo buttons are removed

🤖 Generated with Claude Code

…, and key insertion

Add per-keycap matrix position editor with directional arrows (▲▼◀▶)
that skip to the nearest available row/col to prevent duplicates. Display
layout array index on each keycap to show keymap.c correspondence. Add
index field to Add Key dialog for inserting keys at specific positions
with automatic shifting of existing keys. Remove undo/redo (incompatible
with 2-way binding auto-apply). Default new key row/col to max+1.

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
@yoichiro yoichiro merged commit 6bf2d12 into main Apr 5, 2026
1 check passed
@yoichiro yoichiro deleted the feature/workbench-layout-editor-enhancements branch April 5, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant